DEVX-8: fix: expand DEFAULT_INFRASTRUCTURE to cover all common project files

This commit is contained in:
emil
2026-06-22 21:12:16 +00:00
parent 8ea044a942
commit 53990dc10c
3 changed files with 43 additions and 1 deletions
+1 -1
View File
@@ -1 +1 @@
DEVX-7 DEVX-8
+9
View File
@@ -271,19 +271,28 @@ DEFAULT_INFRASTRUCTURE: list[str] = [
# Build tooling # Build tooling
"Makefile", "Makefile",
"cliff.toml", "cliff.toml",
"uv.lock",
# Linting / formatting config # Linting / formatting config
".pre-commit-config.yaml", ".pre-commit-config.yaml",
".ruff.toml", ".ruff.toml",
".ansible-lint", ".ansible-lint",
".checkmake.ini",
".editorconfig",
# Environment templates (not the actual .env which is gitignored) # Environment templates (not the actual .env which is gitignored)
".env.example", ".env.example",
# Git config # Git config
".gitignore", ".gitignore",
".gitattributes",
# Project-level documentation (not part of the installed package) # Project-level documentation (not part of the installed package)
"AGENTS.md", "AGENTS.md",
"README.md", "README.md",
"CHANGELOG.md", "CHANGELOG.md",
"TROUBLESHOOTING.md", "TROUBLESHOOTING.md",
"CONTRIBUTING.md",
"CODE_OF_CONDUCT.md",
"REVIEW_CHECKLIST.md",
# Agent/CI tooling config (not part of the installed package)
".devin/**",
# Generated venv activation scripts (created by `make setup`) # Generated venv activation scripts (created by `make setup`)
"activate.sh", "activate.sh",
"activate.fish", "activate.fish",
+33
View File
@@ -178,6 +178,39 @@ class TestClassifierConfig:
assert "tests/**" in DEFAULT_INFRASTRUCTURE assert "tests/**" in DEFAULT_INFRASTRUCTURE
assert "docs/**" in DEFAULT_INFRASTRUCTURE assert "docs/**" in DEFAULT_INFRASTRUCTURE
def test_default_infrastructure_covers_common_project_files(self) -> None:
"""DEFAULT_INFRASTRUCTURE must cover common project-level files
that are not part of the installed package.
This test prevents regression of the root cause of GRM-64
misclassification: 28 files (scripts/**, REVIEW_CHECKLIST.md)
were classified as user-facing because these patterns were
missing from the defaults.
"""
# Project documentation
assert "AGENTS.md" in DEFAULT_INFRASTRUCTURE
assert "README.md" in DEFAULT_INFRASTRUCTURE
assert "CHANGELOG.md" in DEFAULT_INFRASTRUCTURE
assert "TROUBLESHOOTING.md" in DEFAULT_INFRASTRUCTURE
assert "CONTRIBUTING.md" in DEFAULT_INFRASTRUCTURE
assert "CODE_OF_CONDUCT.md" in DEFAULT_INFRASTRUCTURE
assert "REVIEW_CHECKLIST.md" in DEFAULT_INFRASTRUCTURE
# Build tooling
assert "Makefile" in DEFAULT_INFRASTRUCTURE
assert "cliff.toml" in DEFAULT_INFRASTRUCTURE
assert "uv.lock" in DEFAULT_INFRASTRUCTURE
# Lint config
assert ".pre-commit-config.yaml" in DEFAULT_INFRASTRUCTURE
assert ".ruff.toml" in DEFAULT_INFRASTRUCTURE
assert ".ansible-lint" in DEFAULT_INFRASTRUCTURE
assert ".checkmake.ini" in DEFAULT_INFRASTRUCTURE
assert ".editorconfig" in DEFAULT_INFRASTRUCTURE
# Git config
assert ".gitignore" in DEFAULT_INFRASTRUCTURE
assert ".gitattributes" in DEFAULT_INFRASTRUCTURE
# Agent config
assert ".devin/**" in DEFAULT_INFRASTRUCTURE
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# ChangeClassifier tests # ChangeClassifier tests