DEVX-91: refactor: add find_task_by_identifier, config fallbacks for tools

tests/unit/test_api_clients.py

@@ -781,6 +781,42 @@ class TestVikunjaClient:
         call_kwargs = client._session.request.call_args.kwargs
         assert call_kwargs["json"]["description"] == ""
 
+    def test_find_task_by_identifier_found(self) -> None:
+        client = VikunjaClient("https://work.example.com", "tok")
+        client._session.request = MagicMock(
+            return_value=_mock_response([{"identifier": "DEVX-1"}, {"identifier": "DEVX-42", "title": "Found"}])
+        )
+        result = client.find_task_by_identifier(6, "DEVX-42", per_page=50)
+        assert result is not None
+        assert result["title"] == "Found"
+
+    def test_find_task_by_identifier_not_found(self) -> None:
+        client = VikunjaClient("https://work.example.com", "tok")
+        client._session.request = MagicMock(
+            return_value=_mock_response([{"identifier": "DEVX-1"}, {"identifier": "DEVX-2"}])
+        )
+        result = client.find_task_by_identifier(6, "DEVX-99", per_page=50)
+        assert result is None
+
+    def test_find_task_by_identifier_empty_project(self) -> None:
+        client = VikunjaClient("https://work.example.com", "tok")
+        client._session.request = MagicMock(return_value=_mock_response([]))
+        result = client.find_task_by_identifier(6, "DEVX-1", per_page=50)
+        assert result is None
+
+    def test_find_task_by_identifier_paginates(self) -> None:
+        client = VikunjaClient("https://work.example.com", "tok")
+        full_page = [{"identifier": f"DEVX-{i}"} for i in range(50)]
+        client._session.request = MagicMock(
+            side_effect=[
+                _mock_response(full_page),
+                _mock_response([{"identifier": "DEVX-50", "title": "Found on page 2"}]),
+            ]
+        )
+        result = client.find_task_by_identifier(6, "DEVX-50", per_page=50)
+        assert result is not None
+        assert result["title"] == "Found on page 2"
+
 
 class TestIsRetryable:
     def test_connection_error_is_retryable(self) -> None:

tests/unit/test_build_image.py

@@ -705,4 +705,33 @@ class TestCLICleanImages:
                         )
                         assert result.exit_code != 0
                         assert "FAILED" in result.output
-                        assert "failed" in result.output.lower()
+
+    @patch("devx.tools.clean_images.REPO_OWNER", "oblachno-oss")
+    def test_owner_from_config(self) -> None:
+        from devx.tools.clean_images import main as clean_main
+
+        runner = CliRunner()
+        mock_resp = MagicMock()
+        mock_resp.json.return_value = []
+        mock_resp.raise_for_status = MagicMock()
+        with patch.dict("os.environ", {"CI_GITEA_TOKEN": "fake"}):
+            with patch("devx.tools.clean_images.requests.get", return_value=mock_resp):
+                result = runner.invoke(
+                    clean_main,
+                    ["--name", "ci-base", "--dry-run"],
+                )
+                assert result.exit_code == 0
+                assert "oblachno-oss/ci-base" in result.output
+
+    @patch("devx.tools.clean_images.REPO_OWNER", "")
+    def test_no_owner_raises(self) -> None:
+        from devx.tools.clean_images import main as clean_main
+
+        runner = CliRunner()
+        with patch.dict("os.environ", {"CI_GITEA_TOKEN": "fake"}):
+            result = runner.invoke(
+                clean_main,
+                ["--name", "ci-base"],
+            )
+            assert result.exit_code != 0
+            assert "owner" in result.output.lower()

tests/unit/test_check_test_coverage.py

@@ -3,6 +3,8 @@
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
+from click.testing import CliRunner
+
 from devx.tools.check_test_coverage import (
     BUILTIN_RULES,
     DEFAULT_SKIP_EXTENSIONS,
@@ -13,7 +15,7 @@ from devx.tools.check_test_coverage import (
     _load_rules,
     _resolve_test_path,
     _should_skip_file,
-    main,
+    cli,
 )
 
 
@@ -201,7 +203,10 @@ class TestMain:
             ),
             patch("devx.tools.check_test_coverage.Path.cwd", return_value=tmp_path),
         ):
-            assert main([]) == 0
+            runner = CliRunner()
+            result = runner.invoke(cli, [])
+            assert result.exit_code == 0
+            assert "No changed files" in result.output
 
     def test_all_have_tests(self, tmp_path: Path) -> None:
         (tmp_path / "scripts" / "tests").mkdir(parents=True)
@@ -214,7 +219,10 @@ class TestMain:
             ),
             patch("devx.tools.check_test_coverage.Path.cwd", return_value=tmp_path),
         ):
-            assert main([]) == 0
+            runner = CliRunner()
+            result = runner.invoke(cli, [])
+            assert result.exit_code == 0
+            assert "have tests" in result.output
 
     def test_missing_test_returns_1(self, tmp_path: Path) -> None:
         with (
@@ -225,7 +233,9 @@ class TestMain:
             ),
             patch("devx.tools.check_test_coverage.Path.cwd", return_value=tmp_path),
         ):
-            assert main([]) == 1
+            runner = CliRunner()
+            result = runner.invoke(cli, [])
+            assert result.exit_code != 0
 
     def test_warn_only_returns_0(self, tmp_path: Path) -> None:
         with (
@@ -236,4 +246,6 @@ class TestMain:
             ),
             patch("devx.tools.check_test_coverage.Path.cwd", return_value=tmp_path),
         ):
-            assert main(["--warn-only"]) == 0
+            runner = CliRunner()
+            result = runner.invoke(cli, ["--warn-only"])
+            assert result.exit_code == 0

tests/unit/test_configure_repo.py

@@ -145,6 +145,7 @@ class TestMain:
         assert "CI_GITEA_TOKEN" in result.output
 
     @patch.dict("os.environ", {"CI_GITEA_TOKEN": "tok"}, clear=True)
+    @patch("devx.tools.configure_repo.REPO_NAME", "")
     def test_main_no_repo(self) -> None:
         runner = CliRunner()
         result = runner.invoke(main, [])
@@ -197,3 +198,19 @@ class TestMain:
         call_args = mock_client_cls.call_args
         assert call_args[0][2] == "oblachno"  # owner
         assert call_args[0][3] == "infra"  # repo
+
+    @patch.dict("os.environ", {"CI_GITEA_TOKEN": "tok"}, clear=True)
+    @patch("devx.tools.configure_repo.REPO_NAME", "devx")
+    @patch("devx.tools.configure_repo.REPO_OWNER", "oblachno-oss")
+    @patch("devx.tools.configure_repo.GiteaClient")
+    def test_main_repo_from_pyproject(self, mock_client_cls: MagicMock) -> None:
+        """When no env var is set, repo name should come from pyproject.toml."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+
+        runner = CliRunner()
+        result = runner.invoke(main, [])
+        assert result.exit_code == 0
+        call_args = mock_client_cls.call_args
+        assert call_args[0][2] == "oblachno-oss"  # owner
+        assert call_args[0][3] == "devx"  # repo

tests/unit/test_create_pr.py

@@ -56,7 +56,7 @@ class TestGetVikunjaTaskTitle:
     @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
     def test_found(self, mock_client_cls: MagicMock) -> None:
         mock_client = MagicMock()
-        mock_client.list_project_tasks.return_value = [{"identifier": "DEVX-42", "title": "Add feature"}]
+        mock_client.find_task_by_identifier.return_value = {"identifier": "DEVX-42", "title": "Add feature"}
         mock_client_cls.return_value = mock_client
         assert get_vikunja_task_title("DEVX-42") == "Add feature"
 
@@ -69,20 +69,7 @@ class TestGetVikunjaTaskTitle:
     @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
     def test_not_found(self, mock_client_cls: MagicMock) -> None:
         mock_client = MagicMock()
-        mock_client.list_project_tasks.return_value = []
-        mock_client_cls.return_value = mock_client
-        with pytest.raises(click.ClickException, match="Could not find"):
-            get_vikunja_task_title("DEVX-42")
-
-    @patch("devx.tools.create_pr.VikunjaClient")
-    @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
-    def test_pagination_not_found(self, mock_client_cls: MagicMock) -> None:
-        from devx.config import DEFAULT_PER_PAGE
-
-        mock_client = MagicMock()
-        page1 = [{"identifier": f"OTHER-{i}"} for i in range(DEFAULT_PER_PAGE)]
-        page2 = [{"identifier": "OTHER-99"}]
-        mock_client.list_project_tasks.side_effect = [page1, page2]
+        mock_client.find_task_by_identifier.return_value = None
         mock_client_cls.return_value = mock_client
         with pytest.raises(click.ClickException, match="Could not find"):
             get_vikunja_task_title("DEVX-42")

tests/unit/test_install_checkmake.py

@@ -63,13 +63,19 @@ class TestDownloadBinary:
 
 class TestMain:
     def test_already_installed(self) -> None:
+        from click.testing import CliRunner
+
         with patch("shutil.which", return_value="/usr/bin/checkmake"):
-            install_checkmake.main()
+            runner = CliRunner()
+            runner.invoke(install_checkmake.cli, [])
 
     def test_install_with_go(self) -> None:
+        from click.testing import CliRunner
+
         with patch("shutil.which", side_effect=[None, "/usr/bin/go"]):
             with patch("subprocess.run") as mock_run:
-                install_checkmake.main()
+                runner = CliRunner()
+                runner.invoke(install_checkmake.cli, [])
                 mock_run.assert_called_once_with(
                     [
                         "/usr/bin/go",
@@ -80,6 +86,8 @@ class TestMain:
                 )
 
     def test_download_when_no_go(self, tmp_path: Path) -> None:
+        from click.testing import CliRunner
+
         target = tmp_path / "checkmake"
 
         def _write_file(url: str, path: str) -> tuple[str, None]:
@@ -90,5 +98,6 @@ class TestMain:
             with patch("shutil.which", side_effect=[None, None]):
                 with patch.object(platform, "machine", return_value="x86_64"):
                     with patch("urllib.request.urlretrieve", side_effect=_write_file) as mock_retrieve:
-                        install_checkmake.main()
+                        runner = CliRunner()
+                        runner.invoke(install_checkmake.cli, [])
                         mock_retrieve.assert_called_once()

tests/unit/test_pre_push_check.py

@@ -43,7 +43,7 @@ class TestTaskExists:
     @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
     def test_found(self, mock_client_cls: MagicMock) -> None:
         mock_client = MagicMock()
-        mock_client.list_project_tasks.return_value = [{"identifier": "DEVX-42"}]
+        mock_client.find_task_by_identifier.return_value = {"identifier": "DEVX-42"}
         mock_client_cls.return_value = mock_client
         assert task_exists("DEVX-42") is True
 
@@ -51,7 +51,7 @@ class TestTaskExists:
     @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
     def test_not_found(self, mock_client_cls: MagicMock) -> None:
         mock_client = MagicMock()
-        mock_client.list_project_tasks.return_value = [{"identifier": "DEVX-99"}]
+        mock_client.find_task_by_identifier.return_value = None
         mock_client_cls.return_value = mock_client
         assert task_exists("DEVX-42") is False
 
@@ -59,37 +59,6 @@ class TestTaskExists:
     def test_no_token(self) -> None:
         assert task_exists("DEVX-42") is False
 
-    @patch("devx.tools.pre_push_check.VikunjaClient")
-    @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
-    def test_pagination(self, mock_client_cls: MagicMock) -> None:
-        mock_client = MagicMock()
-        # First page: full page (50 items, none matching), second page: match
-        page1 = [{"identifier": f"OTHER-{i}"} for i in range(50)]
-        page2 = [{"identifier": "DEVX-42"}]
-        mock_client.list_project_tasks.side_effect = [page1, page2]
-        mock_client_cls.return_value = mock_client
-        assert task_exists("DEVX-42") is True
-
-    @patch("devx.tools.pre_push_check.VikunjaClient")
-    @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
-    def test_empty_project(self, mock_client_cls: MagicMock) -> None:
-        mock_client = MagicMock()
-        mock_client.list_project_tasks.return_value = []
-        mock_client_cls.return_value = mock_client
-        assert task_exists("DEVX-42") is False
-
-    @patch("devx.tools.pre_push_check.VikunjaClient")
-    @patch.dict("os.environ", {"VIKUNJA_TOKEN": "tok"})
-    def test_pagination_not_found(self, mock_client_cls: MagicMock) -> None:
-        from devx.config import DEFAULT_PER_PAGE
-
-        mock_client = MagicMock()
-        page1 = [{"identifier": f"OTHER-{i}"} for i in range(DEFAULT_PER_PAGE)]
-        page2 = [{"identifier": "OTHER-99"}]
-        mock_client.list_project_tasks.side_effect = [page1, page2]
-        mock_client_cls.return_value = mock_client
-        assert task_exists("DEVX-42") is False
-
 
 class TestValidate:
     def test_master_branch_skips(self) -> None: